Clean up inconsistencies in the directory where the tests are run from#588
Merged
Conversation
Member
Author
|
This ended up (again) wit far more changes than I thought at first. The reason being, on top of launching test from the corresponding docker user home, I also added a shared space in all CIs (but LocalCluster) to be able to launch some tests (for the time being, Security related tests). So now, except the fact that some CIs are running with non privileged users inside Docker (PBS and HTCondor) and others are not, the setup from each CI is similar. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #374.
The idea to fix the issue is to alway cd in the submitting user $HOME directory, even if the submitting user is root. I think this is the correct approach as this is closer to a real case setup. At one point, we might want to add a non root submit user to other CI. HTCondor already has one like PBS.